Skip to content

fix: honor deprecated experimental flags instead of ignoring them - #532

Merged
not-matthias merged 1 commit into
mainfrom
fix/deprecated-experimental-flags
Sep 18, 2026
Merged

not-matthias merged 1 commit into
mainfrom
fix/deprecated-experimental-flags

Conversation

@not-matthias

@not-matthias not-matthias commented Sep 8, 2026

Copy link
Copy Markdown
Member

--experimental-cycle-estimation and --experimental-exclude-allocations were parsed but deliberately dropped. Since --exclude-allocations defaults to false, anyone still passing the old flag silently lost allocation exclusion.

Both now feed their graduated counterparts, and the warning states the truth instead of "has no effect":

⚠ --experimental-exclude-allocations is deprecated and will be removed in a future release: use --exclude-allocations instead.

Closes COD-3511

@greptile-apps

greptile-apps Bot commented Sep 8, 2026

Copy link
Copy Markdown

RetriggerConfidence Score: 5/5

The PR appears safe to merge, with no outstanding findings in the scoring set.

Summary

This PR restores support for the deprecated cycle-estimation and allocation-exclusion flags by combining them with their graduated counterparts for both run and exec.

  • Adds shared resolution helpers for stable and deprecated flags.
  • Uses the resolved values when constructing orchestrator configurations.
  • Updates deprecation messaging to direct users to the stable flags.

Reviews (3) · Last reviewed commit: "fix: honor deprecated experimental flags..."

Comment thread src/cli/shared.rs
Comment thread src/cli/experimental.rs
@codspeed

codspeed Bot commented Sep 8, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

✅ 23 untouched benchmarks


Comparing fix/deprecated-experimental-flags (7150303) with main (6c953d6)

Open in CodSpeed

@not-matthias
not-matthias force-pushed the fix/deprecated-experimental-flags branch from 1cf5a8b to e11c9df Compare September 8, 2026 14:16
Comment thread src/cli/experimental.rs Outdated
`--experimental-cycle-estimation` and `--experimental-exclude-allocations`
were parsed but deliberately dropped, so anyone still passing
`--experimental-exclude-allocations` silently lost allocation exclusion.

Both now feed their graduated counterparts and warn that they are
deprecated and will be removed in a future release.
@not-matthias
not-matthias force-pushed the fix/deprecated-experimental-flags branch from 5604158 to 7150303 Compare September 18, 2026 16:26
@not-matthias
not-matthias merged commit 7150303 into main Sep 18, 2026
51 checks passed
@not-matthias
not-matthias deleted the fix/deprecated-experimental-flags branch September 18, 2026 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants