fix: honor deprecated experimental flags instead of ignoring them - #532
Merged
Merged
Conversation
|
Merging this PR will not alter performance
|
not-matthias
force-pushed
the
fix/deprecated-experimental-flags
branch
from
September 8, 2026 14:16
1cf5a8b to
e11c9df
Compare
GuillaumeLagrange
approved these changes
Sep 18, 2026
`--experimental-cycle-estimation` and `--experimental-exclude-allocations` were parsed but deliberately dropped, so anyone still passing `--experimental-exclude-allocations` silently lost allocation exclusion. Both now feed their graduated counterparts and warn that they are deprecated and will be removed in a future release.
not-matthias
force-pushed
the
fix/deprecated-experimental-flags
branch
from
September 18, 2026 16:26
5604158 to
7150303
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--experimental-cycle-estimationand--experimental-exclude-allocationswere parsed but deliberately dropped. Since--exclude-allocationsdefaults tofalse, anyone still passing the old flag silently lost allocation exclusion.Both now feed their graduated counterparts, and the warning states the truth instead of "has no effect":
Closes COD-3511