Skip to content

fix(analytics): 인라인 스크립트 보간 제거로 XSS 잠재 위험 차단 #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CoBool merged 1 commit into from
Aug 16, 2026
Merged

fix(analytics): 인라인 스크립트 보간 제거로 XSS 잠재 위험 차단 #94

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions src/components/google-analytics.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,16 +10,11 @@ export function GoogleAnalytics({ config }: GoogleAnalyticsProps) {
}

const gtagSource = `https://www.googletagmanager.com/gtag/js?id=${encodeURIComponent(config.measurementId)}`
const inlineConfig = `
window.dataLayer = window.dataLayer || [];
function gtag(){dataLayer.push(arguments);}
gtag('js', new Date());
gtag('config', '${config.measurementId}');
`
const inlineConfig = `window.dataLayer=window.dataLayer||[];function gtag(){dataLayer.push(arguments);}gtag('js',new Date());var el=document.querySelector('script[data-ga-measurement-id]');if(el){var id=el.getAttribute('data-ga-measurement-id');if(id)gtag('config',id);}`

return (
<>
<script src={gtagSource} async />
<script async data-ga-measurement-id={config.measurementId} src={gtagSource} />
<script>{inlineConfig}</script>
</>
)
Expand Down
11 changes: 11 additions & 0 deletions tests/stage-7-seo-feed-integrations.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,17 @@ describe("stage 7 seo feed and integration gates", () => {
expect(integrations.kakao.enabled).toBe(true)
})

it("Given enabled GA config When rendering GoogleAnalytics Then scripts are properly configured with data attribute", () => {
const integrations = getPublicIntegrations({
NEXT_PUBLIC_GA_MEASUREMENT_ID: "G-ABC123DEF4",
})
const markup = renderToStaticMarkup(<GoogleAnalytics config={integrations.ga4} />)

expect(markup).toContain('data-ga-measurement-id="G-ABC123DEF4"')
expect(markup).toContain("https://www.googletagmanager.com/gtag/js?id=G-ABC123DEF4")
expect(markup).toContain("gtag('config',id)")
})

it("Given missing public integration env When rendering gates Then no broken scripts or iframes render", () => {
const integrations = getPublicIntegrations({})
const markup = renderToStaticMarkup(
Expand Down