You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Summary
Adds a new GitHub Actions workflow .github/workflows/jvm-compatibility.yml (134 lines) that builds all modules with Temurin JDK 8/11/17, then compiles the example projects across a matrix of JDKs (8, 11, 17, 21, 25) and vendors (openjdk, temurin, amazon/corretto), and runs a Docker-based ClickHouse smoke test of the examples/client app. To make the examples compile under newer JDKs, it also bumps Kotlin 2.0.20 → 2.4.10 in examples/demo-kotlin-service/pom.xml and adds Lombok 1.18.42 as an explicit annotation-processor path in examples/demo-service/pom.xml. No library source code is touched; the release workflow is not modified.
What this impacts
CI only: new jvm-compatibility workflow triggered on push to main, PRs, and manual dispatch (with optional PR ref checkout).
Example projects (examples/demo-kotlin-service, examples/demo-service) — build configuration only, no shipped artifacts.
Concerns
Medium rule fired: changes in the .github directory (new workflow), though not the release workflow.
Actions are SHA-pinned, but actions/setup-java is pinned to a commit annotated # main rather than a release tag — worth confirming the pinned SHA is intentional/trusted.
Bundles example dependency changes (Kotlin minor bump, Lombok processor) with the workflow; related but reviewers should verify they're required for the new JDK matrix.
No linked issue; PR checklist items are unchecked.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Checklist
Delete items not relevant to your PR: