Skip to content

Hyper Parquet: Disable sampling #1396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vogelsgesang wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −2
Open

Hyper Parquet: Disable sampling #1396

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion hyper-parquet-partitioned/start
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,12 @@ signal.signal(signal.SIGINT, _terminate)

with HyperProcess(
telemetry=Telemetry.DO_NOT_SEND_USAGE_DATA_TO_TABLEAU,
parameters={"experimental_persisted_external_tables": "on"},
parameters={
"experimental_persisted_external_tables": "on",
# External-table samples are useful for complex queries but meaningless
# for ClickBench's rather simple queries
"external_sampling": "false",
},
) as hyper:
# Keep-alive: hold hits_parquet.hyper attached for the server lifetime so
# its external-table catalog (and the plan-cache entries depending on it)
Expand Down
7 changes: 6 additions & 1 deletion hyper-parquet-single/start
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,12 @@ signal.signal(signal.SIGINT, _terminate)

with HyperProcess(
telemetry=Telemetry.DO_NOT_SEND_USAGE_DATA_TO_TABLEAU,
parameters={"experimental_persisted_external_tables": "on"},
parameters={
"experimental_persisted_external_tables": "on",
# External-table samples are not persisted, so every cold restart would
# otherwise resample the wide Parquet table before executing the query.
"external_sampling": "false",
},
) as hyper:
# Keep-alive: hold hits_parquet.hyper attached for the server lifetime so
# its external-table catalog (and the plan-cache entries depending on it)
Expand Down