Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related to #2942. The read-only/unaccepted-value fix is already in Puppeteer (puppeteer/puppeteer#15603) and this repository has updated that dependency. This is test-only coverage, not a new implementation of that fix.
The two handler tests verify that a rejected locator fill does not append success output, wait results or a snapshot, and that
fill_formstops before attempting the next field. They use the existing mocks and exercise the actual handler action callback.Only
tests/tools/input.test.tschanges. The tests cover propagation of a locator rejection; they do not independently test browser read-only/input-sanitization behavior.Verification
Tested commit:
5e68bd1d6f72760bc7fc1a5f99dc0ed313bfbc05, based onada7963246c0c91eae185125a57aecd13cbe0376.Isolated fork validation job on Ubuntu, Node 22.23.3:
npm ciandnpm run bundle: passed.npm run test -- --test-concurrency=1: 1764 passed, 0 failed, 0 cancelled, 2 skipped. The two skips are existing Windows-only cases.npm run test:notices:no-build: 1 passed.npm run typecheck,npm run check-format: passed.npm run genfollowed bygit diff --exit-code: passed.The unchanged baseline was run with the same setup (1762 passed, 2 skipped). Final test names were compared with the baseline: no existing tests were missing.
Additional Windows focused validation:
npm run test -- tests/tools/input.test.ts --test-concurrency=1: 48 passed (Windows browser cleanup warnings were also emitted).Windows full-suite success is not claimed: the unchanged baseline and candidates fail the same ConfigWatcher symlink test with
EPERMon this workstation. Earlier parallel Node 24 runs returned success but inconsistent completed-test counts, so those were not used as the full-suite acceptance evidence. The upstream CI matrix remains separate from this fork validation.Prepared and verified with AI assistance (Hermes Agent).