Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related to #2947. Preserve the existing Puppeteer matching behavior and improve its documentation and timeout diagnostics. This does not implement whitespace normalization or regex matching.
textContent; rethrow the original error and leave non-timeout errors unchanged.Verification
Tested commit:
e9339e252e225fcb48d58ed806b7735034235f49, based onada7963246c0c91eae185125a57aecd13cbe0376.Isolated fork validation job on Ubuntu, Node 22.23.3:
npm ciandnpm run bundle: passed.npm run test -- --test-concurrency=1: 1766 passed, 0 failed, 0 cancelled, 2 skipped. The two skips are existing Windows-only cases.npm run test:notices:no-build: 1 passed.npm run typecheck,npm run check-format: passed.npm run genfollowed bygit diff --exit-code: passed.The unchanged baseline was run with the same setup (1762 passed, 2 skipped). Final test names were compared with the baseline: no existing tests were missing.
Additional Windows focused validation:
npm run test -- tests/tools/snapshot.test.ts --test-concurrency=1: 9 passed.Windows full-suite success is not claimed: the unchanged baseline and candidates fail the same ConfigWatcher symlink test with
EPERMon this workstation. Earlier parallel Node 24 runs returned success but inconsistent completed-test counts, so those were not used as the full-suite acceptance evidence. The upstream CI matrix remains separate from this fork validation.Prepared and verified with AI assistance (Hermes Agent).