Repository navigation
perf(memory): drop async parents of request initiators in NetworkCollector - #3345
Open
thomasbachem wants to merge 1 commit into
Open
thomasbachem wants to merge 1 commit into
thomasbachem wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This drops
initiator.stack.parentfrom every requestNetworkCollectorkeeps. The async parents get there through the debuggercreateTargetUniverse()starts (see #3344), and no tool reads them.With the repro from #3344, the heap now levels off at 52 MB instead of 290 MB on
main. On a Google Calendar tab, an initiator averaged 416 KB, of which 11 KB remain without the async parents.No tool output changes, and console messages and errors still show their async fragments. I edit the object
initiator()returns rather than a copy, since a copy wouldn't free anything. That relies on Puppeteer handing out its own object, which the mocked test can't check.Fixes #3344