Repository navigation
Conversation
wolfib
requested changes
Oct 27, 2026
Author
|
Good catch, thanks! Fixed in a30d89b: after dropping a partial %XX escape, truncateUrl now also drops a trailing incomplete multi-byte UTF-8 sequence back to its lead byte (2-, 3- and 4-byte characters). Added tests for each case plus one confirming a complete character at the cut is kept. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong
truncateUrlcuts a URL at 255 characters. When the cut landed inside a percent-encoded escape (for example%E9%A0%80), the result ended with a partial escape such as%or%Eright before the... <truncated>marker. That fragment is not valid percent-encoding, so the output could be misread.What changed
truncateUrlnow checks whether the first 255 characters end in%or%plus one hex digit. If so, the cut moves back to before the%, so a partial escape is never left behind.data:URLs) are cut at 255 characters as before.Tests
Added cases to
tests/utils/text.test.ts:%E%All of them except the last fail without the fix and pass with it. The last one passes either way and guards against removing too much.