Eclipse Devassist | welcome page blue tick (AST-174459, AST-175665) - #273
Conversation
Implement first-time login behavior for welcome dialog: - Auto-enable all scanners on first login when MCP is enabled - Track user preferences with new userPreferencesSet flag - Disable checkbox when any scanner is customized (grayed out state) - Update tooltips to reflect scanner state Changes: 1. ScannerStateManager: Add userPreferencesSet flag for persistence - isUserPreferencesSet() - Check if user has set preferences - setUserPreferencesSet(boolean) - Mark preferences as set 2. WelcomeDialog: Enhance with first-login initialization - initializeRealtimeState() - Auto-enable all scanners on first login - refreshCheckboxState() - Disable checkbox when preferences customized - updateCheckboxTooltip() - Dynamic tooltips for all states Behavior: - First login (mcpEnabled=true, userPreferencesSet=false): All scanners enabled, checkbox checked and enabled - Customized preferences (any scanner disabled): Checkbox disabled (grayed out), signals user has customized settings - Matches JetBrains implementation pattern for consistency Build: SUCCESS (0 errors, 28 warnings - non-blocking) Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Fix scanner to find manifest files at ANY directory depth, not just root level. Replace root-only scanning (project.members(true)) with recursive traversal that searches entire project tree, matching JetBrains implementation pattern. Changes: 1. Add recursive traversal using IContainer.members() with recursion 2. Use glob pattern matching (already defined in DevAssistConstants) 3. Exclude /node_modules/ directory for performance 4. Reuse existing pattern lists: MANIFEST_FILE_PATTERNS, IAC_SUPPORTED_PATTERNS, CONTAINERS_FILE_PATTERNS 5. Maintain backward compatibility with legacy findAndScanFiles() method Impact: - Multi-module projects now fully scanned (Maven, Gradle, etc) - Nested manifests found (src/main/pom.xml, frontend/package.json, etc) - IaC files at any depth (terraform, docker-compose, etc) - Container files anywhere in tree - Performance improved via node_modules exclusion Before: /src/main/pom.xml (MISSED) /frontend/package.json (MISSED) After: /src/main/pom.xml (FOUND) /frontend/package.json (FOUND) Testing: - Build: SUCCESS (0 errors, 28 warnings) - Compilation: All modules compile - Backward compatible: Existing code unchanged Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
On project open, only scan OSS manifest files. Remove IaC and Container scanning from startup to match JetBrains behavior exactly. Changes: 1. Remove scanIacFiles() call from startWorkspaceFileScanning() 2. Remove scanContainerFiles() call from startWorkspaceFileScanning() 3. Keep only scanManifestFiles() on project initialization 4. Update progress monitor task count: 3 → 1 5. Update task label: "manifest, IaC, and container files" → "OSS manifest files" 6. Add comment explaining behavior matches JetBrains Why: - JetBrains OssScannerCommand: initializeScanner() → scanAllManifestFilesInFolder() - JetBrains IacScannerCommand: initializeScanner() → EMPTY (no scanning) - JetBrains ContainerScannerCommand: initializeScanner() → EMPTY (no scanning) Impact: - Faster project startup (only OSS scan needed) - Feature parity with JetBrains - IaC and Container files are handled by real-time scanner events - Manifest scanning still works via recursive traversal Build: SUCCESS (0 errors, 28 warnings) Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Security Policy Alert: Secret Policy ViolationThis workflow run has been blocked by StepSecurity's secrets policy because it accesses secrets and the workflow file differs from the default branch. Secret references detected:
To approve this workflow, please add the Note: The label must be added by someone other than the PR author (cx-aniket-shinde) or automation bots to ensure proper security review. After the label is added, you can re-run the blocked workflow to proceed. This workflow will be automatically approved once merged into the default branch. For more information, see StepSecurity's Secret Exfiltration Policy documentation. |
Security Policy Alert: Secret Policy ViolationThis workflow run has been blocked by StepSecurity's secrets policy because it accesses secrets and the workflow file differs from the default branch. Secret references detected:
To approve this workflow, please add the Note: The label must be added by someone other than the PR author (cx-aniket-shinde) or automation bots to ensure proper security review. After the label is added, you can re-run the blocked workflow to proceed. This workflow will be automatically approved once merged into the default branch. For more information, see StepSecurity's Secret Exfiltration Policy documentation. |
Original alert (resolved)Security Policy Alert: Actions Policy ViolationThis workflow run has been blocked by StepSecurity's actions policy. Disallowed Actions:
To fix this issue, please modify the workflow to use only allowed actions. Contact your organization administrator to request changes to the allowed actions list if needed. For more information, see StepSecurity's Actions Policy documentation. |
d4a559a
into
feature/devassist_integration
3 participants
No description provided.