test: add unit tests for ModalConfigValidator#6845
Merged
Conversation
Adds a small, focused, additive unit-test file (test/modal-config-validator.test.ts). No existing files are modified or removed. yarn test:ci passes locally. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a focused unit-test file for
ModalConfigValidatorinapp/store/config.ts.Covered behaviour:
max_tokensclamps to[0, 512000](default 1024 on NaN)temperatureclamps to[0, 2]top_pclamps to[0, 1]presence_penalty/frequency_penaltyclamp to[-2, 2]modelpasses through unchangedThe module participates in an import cycle, so it is loaded dynamically in
beforeAll— no source changes required.Notes
yarn test:cipasses locally.Part of a series of small QA-only PRs adding unit coverage for pure helpers.