Repository navigation
chore(deps): pin ethermint-cronos with serialized state-diff reads - #10
Merged
Merged
Conversation
Picks up Chaintable/ethermint-cronos#15, which takes the consensus ABCI mutex around every state-diff read of the live IAVL store. Without it the emitter races block execution and the writer forks: reproduced on lihe-dev with the production v1.7.8-ct.3-rocksdb image, where H86175310 re-credited a stale fee collector balance left by H86175308.
Signed-off-by: lihe <he.li@debank.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Picks up Chaintable/ethermint-cronos#15, merged as
9e21f2ac042e482bf784df7bdbe79a8643eb1d71.The DeBank state-diff emitter reads the writer's live
*iavl.Storefrom a JSON-RPC goroutine. Without serialization, those reads race block execution oniavl.MutableTree, and block execution can observe stale cached values.Reproduced end to end
On lihe-dev, production image
cronos-writer:v1.7.8-ct.3-rocksdbrestored from production seed snapshotsnap-0b68938e9a8f624b6, driven by productionbackground-tracer:amd64-v0.1.43with--process-tip-lag=1:wrong Block.Header.AppHashafter 3 minutes and the node stopped at H86175310.What changes
github.com/Chaintable/ethermint-cronostov0.22.1-0.20260807063213-9e21f2ac042e.go.sumandgomod2nix.toml; this also brings the stale CometBFT Nix pin in line with the existinggo.modreplacement.Verification
GOWORK=off go mod verifyGOWORK=off go build ./...GOWORK=off go test -count=1 ./app ./cmd/cronosdgomod2nixregeneration is stable.