Repository navigation
docs: put release footers in the commit itself; cut v0.3.0 (#63) - #66
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
#64 was merged with an empty squash body, so its
Release-As: v0.3.0footer missedmain, as it had for #60 and #62. Release run37774150988was cancelled before tagging. The cause: the footer only ever existed in a separate merge-message file. GitHub's default squash message for a single-commit PR is the commit's own message, and that commit had no body.This PR's single commit carries the footer in its own message, so a default "Squash and merge" (web or CLI, no custom message) keeps it.
docs/release-versioning.mdnow recommends this, and its worked examples record #64.Closes #63
Dry run (simulated default squash = commit message +
(#N))Merge: plain "Squash and merge" with the default message. Don't rebase, and don't replace the body.
Type of change
Testing
scripts/release-version.shon a simulated default squash (above)Checklist