Skip to content

[ENG-12550] 3. Registration metadata edit shows unavailable licenses - #1091

Merged
brianjgeiger merged 7 commits into
CenterForOpenScience:feature/pbs-26-22from
nsemets:fix/ENG-12550
Nov 5, 2026
Merged

brianjgeiger merged 7 commits into
CenterForOpenScience:feature/pbs-26-22from
nsemets:fix/ENG-12550

Conversation

@nsemets

@nsemets nsemets commented Oct 30, 2026

Copy link
Copy Markdown
Collaborator

Summary of Changes

  1. Centralized license fetching in shared LicensesService (project, registration, preprint, collection + by id).
  2. Removed duplicate license fetch logic/mappers across features.
  3. Unified shared LicenseComponent and metadata license dialog for projects and registrations.
  4. Dialog now loads licenses by resource type/provider instead of a global list.
  5. Fixed save/cancel/year defaults and rejected unsupported resource types.
  6. Updated unit tests for the consolidated services, dialog, and components.

Screenshot(s)

image image image

@nsemets
nsemets changed the base branch from feature/pbs-26-20 to feature/pbs-26-22 November 3, 2026 15:42

@brianjgeiger brianjgeiger left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small change request to use the relationship rather than hand-written URLs.

@nsemets
nsemets requested a review from brianjgeiger November 5, 2026 17:17
@brianjgeiger
brianjgeiger merged commit d3cb62d into CenterForOpenScience:feature/pbs-26-22 Nov 5, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants