Skip to content

fix: omit disabled left collapse overlays - #423

Merged
CarlosNZ merged 3 commits into
CarlosNZ:mainfrom
Tabisharaza:fix/disabled-left-collapse-zone
Oct 25, 2026
Merged

CarlosNZ merged 3 commits into
CarlosNZ:mainfrom
Tabisharaza:fix/disabled-left-collapse-zone

Conversation

@Tabisharaza

Copy link
Copy Markdown
Contributor

Render the left click zone only when it is enabled and the collection wrapper is present. Add regression coverage for disabled zones, custom controls, nested collection targeting, and collapseClickZones rerenders.

Fixes #417

Render the left click zone only when it is enabled and the collection
wrapper is present. Add regression coverage for disabled zones, custom
controls, nested collection targeting, and collapseClickZones rerenders.

Fixes CarlosNZ#417
@CarlosNZ

Copy link
Copy Markdown
Owner

Hi @Tabisharaza, sorry, I missed this when you posted it. I'll take a look at it over the weekend, thanks

@CarlosNZ CarlosNZ left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @Tabisharaza 🙏

@github-actions

Copy link
Copy Markdown

Bundle size impact

json-edit-react

Format Base raw PR raw Δ raw Base gzip PR gzip Δ gzip
esm 59.36 KB 59.36 KB 🟢 -6 B (-0.01%) 21.00 KB 21.00 KB ⚪ no change
cjs 60.81 KB 60.80 KB 🟢 -6 B (-0.01%) 21.03 KB 21.02 KB 🟢 -3 B (-0.01%)

Measured from build/index.{cjs,esm}.js. Gzip at level 9.

@CarlosNZ
CarlosNZ merged commit 71d5d2b into CarlosNZ:main Oct 25, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The left click zone is rendered when collapseClickZones excludes 'left', and blocks the content beneath

2 participants