Skip to content

Tier 3 review quality gates (#137) - #159

Merged
w4ffl35 merged 2 commits into
masterfrom
feat/review-gates
Oct 13, 2026
Merged

w4ffl35 merged 2 commits into
masterfrom
feat/review-gates

Conversation

@w4ffl35

@w4ffl35 w4ffl35 commented Oct 13, 2026

Copy link
Copy Markdown
Member

Closes #137.

Deterministic gates (tsc, selected tests for touched files, check-standards, check-architecture) run against the worktree diff BEFORE the LLM review session. Red gates record an automatic finding and skip the session, following the Tier 1 precedent.

Includes:

  • verification-gate.ts: Tier 1 refactored onto shared worktreeChangedFiles list; status -uall so new untracked files are gated per-file instead of collapsing to dir/.
  • test-selection.ts: intel param optional when all files match directly (skips graph load).
  • 6 new tests in review-gates.test.ts; check-standards clean (0 new).

RSI smoke added 2 commits October 13, 2026 11:40
Run tsc, selected tests, and both ratchet checkers against the
worktree diff before the review session; red gates record an
automatic finding and skip the session. Refactor Tier 1 onto a
shared changed-file list; list untracked files individually.
withFixture replaces six copies of the make/cleanup shape. The new
test file's standard main() runner joins the 90-file template set
already in the baseline (regen adds 8 keys, replaces the x90 set
with the x91 set; no other findings affected).
@w4ffl35
w4ffl35 merged commit 4242d8b into master Oct 13, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Review step should run the quality gates (rsi-gate.sh) before verdict=clean

1 participant