Repository navigation
Harden eval-sensitive tests: retry racy group kill, hermetic worktree fixture - #146
Merged
Merged
Conversation
w4ffl35
force-pushed
the
fix/rsi-eval-harness-flakes
branch
2 times, most recently
from
October 13, 2026 09:12
d42ee49 to
c2c5d34
Compare
w4ffl35
force-pushed
the
fix/rsi-eval-harness-flakes
branch
from
October 13, 2026 09:12
c2c5d34 to
75382a0
Compare
Member
Author
|
Note: PR title/body edits are failing (GitHub GraphQL projects error), so the title is stale — the branch now also includes fix 3 (openshell-provider reap TOCTOU: treat a stat-vanished-between-probe-and-read as terminal, same as ESRCH). Commit message is accurate. All gates green locally. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two more RSI baseline blockers found by reading the fleet eval artifacts (run ...00abea81 got to 118/194 files):\n\n1. muse-executor group-kill EPERM: kill(-pgid) can throw for a transient group under load (one strike in a loaded eval sandbox, 10/10 clean container re-runs). Retry briefly with backoff; the muse-is-dead invariant below still fails loudly if the worker survives a signalled group.\n2. run-tests-script worktree test requires the ambient checkout to be a git repo (git worktree add), but eval snapshots extract files without .git — deterministic failure when reached. The fixture now builds its own throwaway parent repo (git init) with an untracked node_modules symlink, preserving the exact walk-up scenario and no longer mutating the real repo's worktree list.\n\nBoth verified locally (5/5 and 12/12) plus tsc clean; full-suite container repro in progress.