Skip to content

test(chrome-extension): add unit test coverage for toSessionDescriptionInit - #2158

Open
gcoinstash-cmd wants to merge 1 commit into
CapSoftware:mainfrom
gcoinstash-cmd:test/webrtc-session-description-init
Open

test(chrome-extension): add unit test coverage for toSessionDescriptionInit#2158
gcoinstash-cmd wants to merge 1 commit into
CapSoftware:mainfrom
gcoinstash-cmd:test/webrtc-session-description-init

Conversation

@gcoinstash-cmd

@gcoinstash-cmd gcoinstash-cmd commented Aug 28, 2026

Copy link
Copy Markdown

Summary of Changes

  • Adds test cases for toSessionDescriptionInit in apps/chrome-extension/src/shared/webrtc.test.ts.
  • Verifies that valid RTCSessionDescription payloads correctly format into RTCSessionDescriptionInit objects and missing descriptions throw informative errors.

Test Validation

  • pnpm --filter=@cap/chrome-extension test: 20/20 unit tests passed 100% green.
  • All extension test suites passed cleanly.

Greptile Summary

Adds focused unit coverage for converting WebRTC session descriptions and rejecting missing descriptions.

  • Verifies that offer type and SDP fields are copied into RTCSessionDescriptionInit.
  • Verifies the missing-description error for null input.

Confidence Score: 4/5

The PR appears safe to merge, with only a non-blocking mismatch between one test’s description and the input it exercises.

The new tests cover the intended conversion and null-error behavior, but the “null or undefined” case only invokes null and should either add an undefined assertion or narrow its name.

Files Needing Attention: apps/chrome-extension/src/shared/webrtc.test.ts

Important Files Changed

Filename Overview
apps/chrome-extension/src/shared/webrtc.test.ts Adds conversion and error-path tests; the second test’s description overstates its exercised inputs by naming undefined without testing it.
Prompt To Fix All With AI
### Issue 1
apps/chrome-extension/src/shared/webrtc.test.ts:68
**Test name overstates coverage**

This test names both `null` and `undefined`, but its only assertion passes `null`, so the suite reports explicit `undefined` coverage that it does not provide.

```suggestion
	it("throws error when session description is null", async () => {
```

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Reviews (1): Last reviewed commit: "test(chrome-extension): add unit test co..." | Re-trigger Greptile

Greptile also left 1 inline comment on this PR.

@superagent-security

Copy link
Copy Markdown

Manage your Superagent protection

Superagent has paused scans for this repository because this unlinked GitHub App installation has used all three included PR scans.

You have 0 of 3 included PR scans remaining.

Create a free account to continue protection, manage scan settings, review security history, and control which repositories are protected.

});
});

it("throws error when session description is null or undefined", async () => {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Test name overstates coverage

This test names both null and undefined, but its only assertion passes null, so the suite reports explicit undefined coverage that it does not provide.

Suggested change
it("throws error when session description is null or undefined", async () => {
it("throws error when session description is null", async () => {
Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/chrome-extension/src/shared/webrtc.test.ts
Line: 68

Comment:
**Test name overstates coverage**

This test names both `null` and `undefined`, but its only assertion passes `null`, so the suite reports explicit `undefined` coverage that it does not provide.

```suggestion
	it("throws error when session description is null", async () => {
```

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant