Firefly-2100: Fix ESLint identified bug

[aventura121]

Firefly-2100: "Triage (or Fix) ESLint-Identified Javascript/React Issues"

Description

This fixes ESLint identified errors with potential behavioral impacts.

I will make a separate ticket for the first one included the Jira ticket related to the use of an async function in a new Promise(). Long story short, while we could make that refactor, it doesn't change the overall behavior; and, it begs the question of what we want to do with the rejection that would be reachable.

Build

https://firefly-2100-eslint-identified-bugs-clean.irsakubedev.ipac.caltech.edu/firefly

Testing

These are syntactic errors or coding oversights that are verifiable via static analysis. I've also added unit tests where appropriate, and included manual steps for the React hook change.

• Unit Testing: where appropriate, I've added unit tests to validate the changes.

• Manual Testing: to validate the CombinedPinnedCharts change, we can load it into the DOM and see it renders:

1. Open the app build above URL.
2. Click Upload from the top nav menu.
3. Select Upload from URL, paste a URL to load spectrum data (e.g. https://firefly-2100-eslint-identified-bugs-clean.irsakubedev.ipac.caltech.edu/firefly/demo/SPITZER_S5_3539456_01_merge.tbl).
4. Click Upload.
5. Make sure to check "Attempt to interpret tables as spectra."
6. Click Load Table.
7. In the chart toolbar, click Pin this chart **twice.
8. Then click the Pinned Charts tab.
9. You should see the Combine charts button (two overlapping circles) at the left of the toolbar. This is the component changed.
10. We can check the dev console for the source to see the change is referenced:

Screenshot