Skip to content

Firefly-2118: Column coordinate guesser is not using UCDs - #2018

Merged
robyww merged 1 commit into
devfrom
FIREFLY-2118-galactic-col
Sep 24, 2026
Merged

robyww merged 1 commit into
devfrom
FIREFLY-2118-galactic-col

Conversation

@robyww

@robyww robyww commented Sep 21, 2026 •

Copy link
Copy Markdown
Contributor

Firefly-2118: Column coordinate guesser is not using UCDs

Testing

@robyww robyww added this to the 2026.3 milestone Sep 21, 2026
@robyww robyww self-assigned this Sep 21, 2026
@robyww robyww added the bug label Sep 21, 2026
@robyww
robyww force-pushed the FIREFLY-2118-galactic-col branch from 3510a3e to 2e7f1b7 Compare September 22, 2026 15:11
@robyww robyww changed the title Firefly-2118: Galactic tables are labeled EQ_J2000 and incorrectly plotted Firefly-2118: Column coordinate guesser is not using UCDs Sep 22, 2026
@robyww
robyww marked this pull request as ready for review September 22, 2026 15:44
@robyww
robyww requested a review from aventura121 September 22, 2026 15:45

@aventura121 aventura121 left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think your changes do find the _Glon _Glat edge case now, but there is a change we could make to not rely on guessing, listed below.

Comment thread src/firefly/js/voAnalyzer/VoTableRecognizer.js
@aventura121
aventura121 dismissed their stale review September 24, 2026 17:40

dismissing based on standup discussion.

@aventura121 aventura121 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving based on standup discussion.

@robyww
robyww merged commit 4c70130 into dev Sep 24, 2026
1 check passed
@robyww
robyww deleted the FIREFLY-2118-galactic-col branch September 24, 2026 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants