Firefly-1259: Fix Table Header Scroll Bug - #2017
Merged
Merged
Conversation
aventura121
changed the title
aventura121
marked this pull request as ready for review
September 18, 2026 14:10
loitly
approved these changes
Sep 21, 2026
loitly
left a comment
loitly
left a comment
Contributor
There was a problem hiding this comment.
I’m unable to reproduce the reported bug anymore. This PR addresses another related bug, which is a bonus.
aventura121
force-pushed
the
FIREFLY-1259-table-header-shift
branch
from
September 21, 2026 19:32
4e23e0d to
5d47e60
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Firefly-1259 "Table header shift to the left after filtering"
Description
The bug here is that the table inherits an overflow: hidden property, which makes the header/rows scrollable to the browser; so, the browser can scroll the header into view directly when focusing to a partially hidden column. (In previous builds like the table in use in NASA's Exoplanet Archive, this behavior was reachable on submit and on tab).
The fix is to set overflow: clip, which removes the scroll container so the browser can't do this from underneath us. This change otherwise preserves existing behavior on tab.
Testing
Build: https://firefly-1259-table-header-shift.irsakubedev.ipac.caltech.edu/firefly
Steps:
Search/load a table, e.g. the suggested Gaia DR3 cone search at M101 (here it is expanded).
Have the rightmost column halfway off the viewport.
Select into the filter input column immediately preceding this rightmost column.
Tab into the the filter input to the right, i.e. click the tab key on your keyboard until the focus/cursor moves into the overflowing input to the right.
Before this change, the header row scrolls.
After this change, the header row does not scroll.
Screen animation showing fix