feat: add maxLabelLength truncation to Header breadcrumb for long labels - #976
Open
waterWang wants to merge 1 commit into
Open
feat: add maxLabelLength truncation to Header breadcrumb for long labels#976waterWang wants to merge 1 commit into
waterWang wants to merge 1 commit into
Conversation
Adds maxLabelLength={28} to the Breadcrumb in Header so that the
first and last visible breadcrumb labels are truncated with a
middle-ellipsis when they exceed 28 characters. The full label is
preserved in title and aria-label for accessibility.
- Add maxLabelLength={28} to Breadcrumb in Header.tsx
- Add 3 tests for maxLabelLength truncation in Header.test.tsx
Closes CalloraOrg#947
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
maxLabelLength={28}to the Breadcrumb in the Header component so that long first and last breadcrumb labels are truncated with a middle-ellipsis when they exceed 28 characters.Changes
maxLabelLength={28}to the Breadcrumb componentAccessibility
The full label text is preserved in the
titleattribute andaria-labeloverride on truncated elements, so screen-reader and hover users always see the complete value.Closes #947