feat: add tabular-nums to MarketplacePage numeric displays (Closes #937) - #975
Open
waterWang wants to merge 3 commits into
Open
feat: add tabular-nums to MarketplacePage numeric displays (Closes #937)#975waterWang wants to merge 3 commits into
waterWang wants to merge 3 commits into
Conversation
GrantFox FWC26 campaign: implement a searchable combobox for filtering API endpoints by title, URL, method, group, and API name. - ARIA combobox pattern with listbox (role=combobox / role=listbox / role=option) - Real-time filtering with relevance scoring - Full keyboard navigation (ArrowDown/Up, Enter, Escape, Home/End) - Screen-reader announcements via LiveRegion - Clear button with accessible label - 33 focused tests covering filtering, selection, keyboard, a11y, and edge cases - scrollIntoView mock added to setupTests for jsdom compatibility
…lloraOrg#937) Fix corrupted MarketplacePage.tsx by removing a duplicate nested component that was introduced by a bad merge. The corrupted section (lines 49-136) contained a nested import statement and a second component definition inside the function body, causing a build error. The tabular-nums classes (.numeric-tabular spans on count displays and .marketplace-filter-badge) were already present in the JSX template and typography.css — this fix restores the file to a valid state so the existing implementation compiles and works correctly. - 9 tabular-nums tests pass: count bar digits, filter badge, belt-and-suspenders - 34/38 tests pass (4 pre-existing empty-state failures unrelated to this change)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix MarketplacePage.tsx by removing a corrupted duplicate nested component that was introduced by a bad merge. The corrupted section (lines 49-136) contained a nested
import Reactstatement and a second component definition inside the function body, causing a build error.The
tabular-nums/.numeric-tabularclasses were already present in the JSX template (count spans, filter badge) andtypography.css— this fix restores the file to a valid state so the existing implementation compiles correctly.Changes
Testing
Closes #937