Polish ApiCard loading skeleton to match final card shape (Closes #935) - #974
Open
waterWang wants to merge 2 commits into
Open
Polish ApiCard loading skeleton to match final card shape (Closes #935)#974waterWang wants to merge 2 commits into
waterWang wants to merge 2 commits into
Conversation
GrantFox FWC26 campaign: implement a searchable combobox for filtering API endpoints by title, URL, method, group, and API name. - ARIA combobox pattern with listbox (role=combobox / role=listbox / role=option) - Real-time filtering with relevance scoring - Full keyboard navigation (ArrowDown/Up, Enter, Escape, Home/End) - Screen-reader announcements via LiveRegion - Clear button with accessible label - 33 focused tests covering filtering, selection, keyboard, a11y, and edge cases - scrollIntoView mock added to setupTests for jsdom compatibility
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Polishes
ApiCardSkeletonto use CSS variable tokens consistently, matching the finalApiCardcomponent's layout dimensions for minimal layout shift (CLS) on data hydration.Changes
src/components/ApiCard.tsx— ApiCardSkeleton12px→var(--mkt-space-lg, 12px)(matches final card)56×56→var(--mkt-card-icon-size, 56px)/var(--mkt-card-icon-radius, 10px)api-marketplace-card-bodyclass andminWidth: 0for layout parityflexWrap: 'wrap'for responsive wrapping4px→var(--mkt-card-margin-top-sm, 4px)36px→var(--mkt-card-price-padding-right, 36px)8px→var(--mkt-space-md, 8px)12px→var(--mkt-space-lg, 12px), addedflexWrap, matchedmarginToptoken12px→var(--mkt-space-lg, 12px)src/components/ApiCard.test.tsx— New testsTesting
Closes #935