feat: polish StickyToc error-boundary fallback UI (Closes #953) - #972
Open
waterWang wants to merge 2 commits into
Open
feat: polish StickyToc error-boundary fallback UI (Closes #953)#972waterWang wants to merge 2 commits into
waterWang wants to merge 2 commits into
Conversation
GrantFox FWC26 campaign: implement a searchable combobox for filtering API endpoints by title, URL, method, group, and API name. - ARIA combobox pattern with listbox (role=combobox / role=listbox / role=option) - Real-time filtering with relevance scoring - Full keyboard navigation (ArrowDown/Up, Enter, Escape, Home/End) - Screen-reader announcements via LiveRegion - Clear button with accessible label - 33 focused tests covering filtering, selection, keyboard, a11y, and edge cases - scrollIntoView mock added to setupTests for jsdom compatibility
) Refactor StickyTocErrorBoundary to reuse the generic ErrorBoundary component with a custom fallback, giving it a polished visual design with: - Danger icon in a rounded circle with danger background - Descriptive error message - Accessible retry button with aria-label All 4 existing tests pass and the component now uses ErrorBoundary's established CSS classes for consistent theming.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Polishes the StickyToc error-boundary fallback UI by refactoring
StickyTocErrorBoundaryto reuse the reusableErrorBoundarycomponent with a custom fallback render prop.Changes
src/components/StickyTocErrorBoundary.tsx— now uses the genericErrorBoundarycomponent with a custom fallback that shows the TOC-specific error UIErrorBoundary.cssclasses for consistent theming (danger icon in a circle with danger background, centered layout, proper spacing)role=alert,aria-live=polite), retry button witharia-label, and TOC heading remain unchangedTesting
All 4 existing tests pass without modification.
Closes #953