fix(a11y): add polite aria-live status region on LoginPage #530 - #969
Open
dami080 wants to merge 1 commit into
Open
fix(a11y): add polite aria-live status region on LoginPage #530#969dami080 wants to merge 1 commit into
dami080 wants to merge 1 commit into
Conversation
Announce LoginPage submitting/success/error status changes for screen readers (Closes CalloraOrg#530).
|
@dami080 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Author
|
@greatest0fallt1me done closes #530 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds a polite
aria-livestatus region to the LoginPage so submitting, success, and error status changes are announced to assistive-technology users (screen readers), instead of relying on the visible status banner alone.Related Issue
Closes #530
Changes
♿ Accessibility
src/pages/LoginPage.tsx/login) using the sharedLiveRegioncomponent witharia-live="polite",role="status",aria-atomic="true".aria-busyon the submit control while in flight; focus moves to the status banner after submit.aria-invalid, andaria-describedbywired up on form fields.src/pages/LoginPage.test.tsxdocs/LoginPage-aria-live.mdsrc/App.tsx/loginroute plus document title/description.README.md/loginroute.Verification Results
/dashboardLiveRegion