Skip to content

fix(a11y): add polite aria-live status region on LoginPage #530 - #969

Open
dami080 wants to merge 1 commit into
CalloraOrg:mainfrom
dami080:fix/530-loginpage-aria-live
Open

fix(a11y): add polite aria-live status region on LoginPage #530#969
dami080 wants to merge 1 commit into
CalloraOrg:mainfrom
dami080:fix/530-loginpage-aria-live

Conversation

@dami080

@dami080 dami080 commented Aug 2, 2026

Copy link
Copy Markdown

Overview

This PR adds a polite aria-live status region to the LoginPage so submitting, success, and error status changes are announced to assistive-technology users (screen readers), instead of relying on the visible status banner alone.

Related Issue

Closes #530

Changes

♿ Accessibility

  • [ADD] src/pages/LoginPage.tsx
    • New mock sign-in page (/login) using the shared LiveRegion component with aria-live="polite", role="status", aria-atomic="true".
    • Announces validation prompts, submitting, success, and failure (with detail) states.
    • aria-busy on the submit control while in flight; focus moves to the status banner after submit.
    • Labels, aria-invalid, and aria-describedby wired up on form fields.
  • [ADD] src/pages/LoginPage.test.tsx
    • Focused tests for live-region announcements and the form status flow (8 tests).
  • [ADD] docs/LoginPage-aria-live.md
    • Documents the live-region implementation, files changed, and accessibility notes.
  • [MODIFY] src/App.tsx
    • Registers the /login route plus document title/description.
  • [MODIFY] README.md
    • Documents the /login route.

Verification Results

npx vitest run src/pages/LoginPage.test.tsx
✅ Test Files  1 passed (1)
✅ Tests       8 passed (8)
Acceptance Criteria Status
Submitting status is announced politely for screen readers ✅ Covered by tests
Success status announced and redirects to /dashboard ✅ Covered by tests
Error status announced with detail ✅ Covered by tests
Live region mirrors the visible status banner ✅ Same messages via LiveRegion

Announce LoginPage submitting/success/error status changes for screen readers (Closes CalloraOrg#530).
@drips-wave

drips-wave Bot commented Aug 2, 2026

Copy link
Copy Markdown

@dami080 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@dami080

dami080 commented Aug 2, 2026

Copy link
Copy Markdown
Author

@greatest0fallt1me done closes #530

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add aria-live region for LoginPage status updates

1 participant