feat(registry): add per-entrypoint gas snapshot for registry [b#028] - #1027
Open
SINCEO2 wants to merge 1 commit into
Open
feat(registry): add per-entrypoint gas snapshot for registry [b#028]#1027SINCEO2 wants to merge 1 commit into
SINCEO2 wants to merge 1 commit into
Conversation
Add contracts/registry/tests/gas_snap.rs capturing CPU instruction count and memory byte usage for every public entrypoint of the registry contract: init, register_offering, register_offering_with_gate, is_offering_registered, registered_count, get_offering. Measurements are emitted as JSON lines harvested by scripts/gas-regression.sh and compared against contracts/.gas-baseline.json so CI fails on >5% regression. Baseline updated with initial registry measurements. Closes CalloraOrg#853
|
@SINCEO2 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a smart-contract issue for the GrantFox FWC26 campaign. Snapshot CPU/memory per call on registry — CI fails on >5% regression.
Requirements and Context
Changes
[ADD]
contracts/registry/tests/gas_snap.rs— per-entrypoint CPU/memory snapshot tests for every public registry entrypoint:initregister_offeringregister_offering_with_gateis_offering_registeredregistered_countget_offeringEach test emits a machine-readable JSON line harvested by
scripts/gas-regression.shand compared againstcontracts/.gas-baseline.json, so CI fails on any >5% CPU or memory regression.[MODIFY]
scripts/gas-regression.sh— harvest the newcallora-registrysnapshot metrics.[MODIFY]
contracts/.gas-baseline.json— record initial registry measurements.Suggested Execution
contracts/registry/tests/gas_snap.rsscripts/gas-regression.shcontracts/.gas-baseline.jsonCloses #<issue-number>in the bodyGuidelines
cargo testrequire_authon every state-changing entrypointunwrap()in production paths///rustdocVerification
Closes #853