Repository navigation
Conversation
Workplane (inPlane), Workplane.translate (vec), Workplane.each (callback), Workplane.twistExtrude (angleDegrees), Workplane.sweep (multisection), Mixin1D.curvatures (ds) and DxfDocument.add_shape (shape) documented their parameters under old names, and Mixin1D.paramsLength also documented a pts parameter it does not take.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2118 +/- ##
=======================================
Coverage 95.81% 95.81%
=======================================
Files 30 30
Lines 9605 9605
Branches 1443 1443
=======================================
Hits 9203 9203
Misses 247 247
Partials 155 155 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some docstrings document parameters under names the functions do not use, so passing them by the documented name fails. I found these by comparing the
:paramfields with the function signatures:Workplane(class docstring):plane→inPlaneWorkplane.translate:tupleDistance→vec(also in:type)Workplane.each:callBackFunction→callback(also in the description)Workplane.twistExtrude:angle→angleDegreesWorkplane.sweep:multiSection→multisectionMixin1D.curvatures:d→dsDxfDocument.add_shape:s→shapeMixin1D.paramsLength: removed:param pts:; the method only takeslocations, which is already documented.Docstring-only change.