Fix Weathermap integration dependencies - #239
Merged
somethingwithproof merged 1 commit intoAug 28, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the GitHub Actions integration workflow to avoid installing Ubuntu-provided, PHP-versioned Apache modules that are not required for this plugin’s integration suite (PHP is provided by shivammathur/setup-php).
Changes:
- Removed
libapache2-mod-php${{ matrix.php }}from the apt dependency install step to prevent matrix failures due to unavailable versioned packages.
xmacan
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The PHP runtime is supplied by
setup-php; the integration suite does not require a versioned Apache module.Validation
git diff --checkKept separate from #238 so the PHP 8 number-formatting fix remains focused.