Skip to content

chore: 릴리즈 — 상품 이미지 상한 6장 #518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chanwoo7 merged 2 commits into from
Oct 5, 2026
Merged

chore: 릴리즈 — 상품 이미지 상한 6장 #518

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2a6324e
feat: 상품 이미지 상한 5 → 6장
chanwoo7 Oct 5, 2026
38b4324
Merge pull request #517 from CaQuick/feat/product-image-limit-6
chanwoo7 Oct 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/features/product/constants/product-seller.constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ export const DEFAULT_PREPARATION_TIME_MINUTES = 180;
export const MIN_PRODUCT_PRICE = 1;
export const MIN_SALE_PRICE = 0;
export const MAX_PRODUCT_PRICE = 1_000_000_000;
export const MAX_PRODUCT_IMAGES = 5;
export const MAX_PRODUCT_IMAGES = 6;
export const MIN_PRODUCT_IMAGES = 1;

// ── 옵션 ──
Expand Down
22 changes: 16 additions & 6 deletions src/features/product/services/product-seller-image.service.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import { AUDIT_LOG_REPOSITORY } from '@/features/audit-log';
import { AuditLogRepository } from '@/features/audit-log/repositories/audit-log.repository';
import { MAX_PRODUCT_IMAGES } from '@/features/product/constants/product-seller.constants';
import { ProductRepository } from '@/features/product/repositories/product.repository';
import { SellerProductImageService } from '@/features/product/services/product-seller-image.service';
import { StoreSellerRepository } from '@/features/store/repositories/store-seller.repository';
Expand Down Expand Up @@ -60,9 +61,10 @@ describe('SellerProductImageService (real DB)', () => {
}

describe('sellerAddProductImage', () => {
it('이미지가 이미 5개면 400 (PRODUCT_IMAGE_LIMIT_EXCEEDED)', async () => {
it('6장째까지 추가되고 7장째는 PRODUCT_IMAGE_LIMIT_EXCEEDED로 거절된다', async () => {
const { account, store } = await setupSellerWithStore(prisma);
const product = await createSellerProduct(store.id);
// 총 5장을 리터럴로 시드한다 — 상한 상수만 바뀌어도 6장째 추가에서 걸린다
for (let i = 1; i <= 4; i++) {
await prisma.productImage.create({
data: {
Expand All @@ -72,13 +74,21 @@ describe('SellerProductImageService (real DB)', () => {
},
});
}

await expect(
const add = (file: string) =>
service.sellerAddProductImage(account.id, {
productId: product.id.toString(),
imageUrl: ownedUploadUrl('PRODUCT_IMAGE', account.id, '6.png'),
}),
).rejects.toThrowDomain(400);
imageUrl: ownedUploadUrl('PRODUCT_IMAGE', account.id, file),
});

await add('6.png');
const seventh = add('7.png');
await expect(seventh).rejects.toThrowDomain(
'PRODUCT_IMAGE_LIMIT_EXCEEDED',
);
await expect(seventh).rejects.toThrow(`최대 ${MAX_PRODUCT_IMAGES}장까지`);
expect(
await prisma.productImage.count({ where: { product_id: product.id } }),
).toBe(MAX_PRODUCT_IMAGES);
});

it('정상 추가', async () => {
Expand Down
Loading