Skip to content

chore: 릴리즈 — 계정 아이디 대문자 허용 - #74

Merged
chanwoo7 merged 7 commits into
mainfrom
develop
Oct 8, 2026
Merged

chanwoo7 merged 7 commits into
mainfrom
develop

Conversation

@chanwoo7

@chanwoo7 chanwoo7 commented Oct 8, 2026

Copy link
Copy Markdown
Member

#72·#73 릴리즈입니다. 계정 아이디 대문자 허용을 배포하고, 리뷰 봇 설정 정리를 함께 내보냅니다. BE 릴리즈 #527(b3fe44f)은 운영에 먼저 배포했습니다.

머지 뒤 develop을 재생성합니다.

- 사용자 결정: CodeRabbit은 BE 전용, FE 레포(관리자·판매자)는 쓰지 않음.
- .coderabbit.yaml 삭제, 봇 리뷰 문서를 Codex만으로, decisions D11 갱신·D17 추가.
- 설정 파일만 지우면 앱 연결이 남은 경우 기본값(auto_review.enabled: true)으로 리뷰가 계속 돎(Codex 지적).
- 삭제 대신 auto_review.enabled: false만 둔 최소 설정, decisions 문구 맞춤.
- 최소 설정에서 이전의 chat.auto_reply: false가 빠져 기본값(true)으로 돌아감(Codex 지적) → 유지.
chore: CodeRabbit 자동 리뷰 끄기(리뷰 봇은 Codex만)
BE #526과 같은 규칙으로 관리자·판매자 생성 폼의 아이디 검증을 완화함.

- 정규식: [a-z0-9._-]{4,80} → [A-Za-z0-9._-]{4,80}(create-admin-schema·create-seller-schema)
- 오류 문구: "영문 소문자" → "영문"
- 도움말: 로그인할 때 대소문자를 구분하지 않는다는 안내 추가(BE 컬럼 정렬이 ci라 대소문자만 다른 아이디는 같은 아이디로 봄)

테스트
- createAdminSchema: 대문자 아이디 허용, 허용 외 문자(@) 거절 케이스 추가
- createSellerSchema: 대문자 거절 케이스를 허용 외 문자로 교체, 대문자 아이디를 입력 그대로 보내는 케이스 추가
- admins 페이지: 바뀐 오류 문구로 맞춤
BE 릴리즈 #527(main b3fe44f) 기준 schema:pull → codegen.

- 생성 타입 변경: AdminCreateAdminInput·AdminCreateSellerInput.username 설명(영문 대소문자 허용)만
- 스냅샷에는 그동안 반영 안 된 판매자 앱용 SDL 추가분도 함께 들어옴(관리자 FE 문서가 쓰지 않아 생성물 영향 없음)
feat: 계정 아이디에 영문 대문자 허용
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-08T02:00:18.698755Z e1887ed PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Oct 8, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: CaQuick/caquick-admin-fe/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 7c988649-d0ac-476f-ab93-c74e0fd48346

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Oct 8, 2026

Copy link
Copy Markdown

Coverage Report

Status Category Percentage Covered / Total
🟢 Lines 96.07% (🎯 96%)
🟰 ±0%
2447 / 2547
🟢 Statements 95.54% (🎯 95%)
🟰 ±0%
2680 / 2805
🟢 Functions 94.29% (🎯 94%)
🟰 ±0%
1008 / 1069
🟢 Branches 88.07% (🎯 88%)
🟰 ±0%
2017 / 2290
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
src/features/account/create-admin-schema.ts 100%
🟰 ±0%
100%
🟰 ±0%
100%
🟰 ±0%
100%
🟰 ±0%
src/features/account/components/create-admin-dialog.tsx 95.23%
🟰 ±0%
83.33%
🟰 ±0%
83.33%
🟰 ±0%
95.23%
🟰 ±0%
140
src/features/sellers/create-seller-schema.ts 100%
🟰 ±0%
100%
🟰 ±0%
100%
🟰 ±0%
100%
🟰 ±0%
src/features/sellers/components/create-seller-form.tsx 100%
🟰 ±0%
100%
🟰 ±0%
100%
🟰 ±0%
100%
🟰 ±0%
Generated in workflow #152 for commit e1887ed by the Vitest Coverage Report Action

@codecov

codecov Bot commented Oct 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@chanwoo7
chanwoo7 merged commit 287ba53 into main Oct 8, 2026
23 checks passed
@chanwoo7
chanwoo7 deleted the develop branch October 8, 2026 02:00
@chanwoo7
chanwoo7 restored the develop branch October 8, 2026 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant