Adding parts of the code that will work with openssl4 - #1829
Merged
Merged
Conversation
michalvasko
requested changes
Sep 18, 2026
michalvasko
left a comment
michalvasko
left a comment
Member
There was a problem hiding this comment.
Are those #ifs required? At least OpenSSL 3.0 is required, which should support the functions you added. Also, please change the target branch to devel, we do not accept PRs into master.
Author
|
TBH, I did not try without those #ifs, let me try that and update the PR. |
Author
|
You're right, this works without the conditional openssl versioning. |
michalvasko
approved these changes
Sep 18, 2026
michalvasko
left a comment
michalvasko
left a comment
Member
There was a problem hiding this comment.
Thanks, now it looks okay.
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding similar changes to what can be found in libnetconf2 devel branch, only conditioned for more general usage with different openssl versions. Let me know if this looks good or not.