Skip to content

session server ssh FEATURE lock an account out after repeated failed password authentication #640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
niklas-moser wants to merge 1 commit into
base: devel
Choose a base branch
from
+446 −0
Open

session server ssh FEATURE lock an account out after repeated failed password authentication #640

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/session_server.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1619,6 +1619,9 @@ nc_server_destroy(void)
ERR(NULL, "%s: failed to stop certificate expiration notification thread.", __func__);
goto cleanup;
}

/* free the password authentication lockout tally, the state file it mirrors is kept */
nc_server_ssh_authlock_free();
Comment on lines +1623 to +1624

@Roytak Roytak Sep 16, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It sits before nc_server_ch_threads_destroy() so Call Home and accept threads are still authenticating clients. Move the call to the end of the teardown, after all threads are joined.

#endif /* NC_ENABLED_SSH_TLS */

/* CONFIG UPDATE LOCK - the same timeout as the appliers use, destroying the server must not
Expand Down
Loading