fix(search): show report numbers and EP badge in search results - #890
fix(search): show report numbers and EP badge in search results#890TahaKhan998 wants to merge 1 commit into
Conversation
7632296 to
98cb4f6
Compare
Added limits to each of those meta lists to two items with an ellipsis when there are more.
|
f9081c6 to
c4e032d
Compare
66a6fba to
27ae4ce
Compare
| </> | ||
| {(cdsReferenceId || accelerators.length > 0 || experiments.length > 0) && ( | ||
| <Item.Meta | ||
| className={ |
There was a problem hiding this comment.
that seems quite complex.... wouldn't work to set a max-width and add the truncate-lines class to enable the ellpsis? @kpsherva ?
There was a problem hiding this comment.
I tried the max-width + truncate-lines approach on the combined meta line. With many accelerators, the ellipsis cuts off before experiments, so that field gets eaten entirely. I went back to giving each part 50% max-width when both are present, so they stay on the same line and both remain visible when truncated.
There was a problem hiding this comment.
I would prefer if we don't add custom CSS for something that was already addressed with truncate-lines in the past. We discussed to have one line for experiments + accelerators and separate line for report numbers. if you do for each truncate-lines-1, why doesn't it work?
There was a problem hiding this comment.
I tried truncate-lines-1 on accelerators and experiments separately (same meta row). they no longer sit on one line and the | separator ends up alone on its own line.
So to keep them side by side we need the extra CSS.
803e4fd to
aaf0af7
Compare
aaf0af7 to
42ef9ac
Compare
4 participants
Closes #888. Registers the CDS search result description override for community search so report numbers, accelerators, and experiments appear there as on main search, shows EP approval numbers (
apprn) as a blue badge in the results label row on both, and limits each of those meta lists to two items with an ellipsis when there are more.