feat(components): Auto submit public records to cern research - #837
Open
sakshamarora1 wants to merge 1 commit into
Open
feat(components): Auto submit public records to cern research#837sakshamarora1 wants to merge 1 commit into
sakshamarora1 wants to merge 1 commit into
Conversation
sakshamarora1
force-pushed
the
feat/auto-submit-publications
branch
2 times, most recently
from
June 30, 2026 15:08
dae678a to
f7663b6
Compare
kpsherva
reviewed
Jul 2, 2026
kpsherva
reviewed
Jul 2, 2026
kpsherva
reviewed
Jul 2, 2026
kpsherva
reviewed
Jul 2, 2026
kpsherva
reviewed
Jul 2, 2026
kpsherva
reviewed
Jul 2, 2026
|
|
||
| try: | ||
| with UnitOfWork() as uow: | ||
| processed, errors = current_record_communities_service.add( |
Contributor
There was a problem hiding this comment.
doesn't it automatically add the community to the record without requiring the review? We discussed that initially we should go through approval, we might switch to automatic approval later on
Contributor
Author
There was a problem hiding this comment.
If that happens, later on we can remove the require_review flag from the data being passed to this service method.
Contributor
There was a problem hiding this comment.
I am confused from all the questions and feedback - is the inclusion request to CERN research auto accepted or not in the end?
Contributor
Author
There was a problem hiding this comment.
sakshamarora1
force-pushed
the
feat/auto-submit-publications
branch
4 times, most recently
from
July 3, 2026 14:26
28ec1dc to
a69b2e5
Compare
sakshamarora1
force-pushed
the
feat/auto-submit-publications
branch
from
July 31, 2026 11:49
a69b2e5 to
941551c
Compare
zzacharo
reviewed
Jul 31, 2026
| "communities": [ | ||
| { | ||
| "id": csc_community_id, | ||
| "require_review": True, |
Contributor
kpsherva
reviewed
Aug 4, 2026
kpsherva
reviewed
Aug 4, 2026
kpsherva
reviewed
Aug 4, 2026
sakshamarora1
force-pushed
the
feat/auto-submit-publications
branch
2 times, most recently
from
August 5, 2026 14:59
149fd7d to
e44b377
Compare
sakshamarora1
force-pushed
the
feat/auto-submit-publications
branch
from
August 5, 2026 15:18
e44b377 to
05ebcb3
Compare
zzacharo
approved these changes
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: #830