fix(importer): stopped incorrect persisting error messages - #1102
Open
callumlewis05 wants to merge 1 commit into
Open
fix(importer): stopped incorrect persisting error messages#1102callumlewis05 wants to merge 1 commit into
callumlewis05 wants to merge 1 commit into
Conversation
callumlewis05
force-pushed
the
persistent-error-messages
branch
from
August 3, 2026 12:56
3328c40 to
9db07f4
Compare
kpsherva
approved these changes
Aug 4, 2026
kpsherva
left a comment
kpsherva
left a comment
Contributor
There was a problem hiding this comment.
if we find ourselves adding more make-shift validation here, maybe it makes sense to add a library which handles a form out of the box, including validation.
I don't remember, do we have a rest API for this feature? is the backend validating the input? I assume you only fixed the frontend because of the state kept in the components, correct?
Contributor
Author
|
This change only edits how it visually looks, I do not think extra validation is needed as it is only from a drop down menu but the validation on clicking preview is ensuring that required fields are filled, which would then not disappear once the fields were being edited, though now returns to normal when the dropdown is opened. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If preview was clicked before all fields had been filled the error messages would display and then persist even when the field had been filled but now disappear once the input is clicked on.