Repository navigation
clamp the last page end index to the row count - #197
Open
arpitjain099 wants to merge 1 commit into
Open
arpitjain099 wants to merge 1 commit into
arpitjain099 wants to merge 1 commit into
Conversation
Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Arpit Jain <arpitjain099@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setting
limiton aQuerymakesget_pages()raiseAssertionError: End index 9999 is larger than limit 5.The loop computes the page end as(i + 1) * page_size - 1and never clamps it to the row count it just resolved, so the last page asks for rows that are not there. With the defaultpage_sizeof 10,000, any limit below 10,000 fails on the first page, and any limit that is not an exact multiple of the page size fails on the last one. Takingmin()againstrow_countfixes both, and it also stops the final page asking for a whole page of rows when no limit is set.One existing assertion changed with it.
test_get_pages_yields_expected_page_rangesexpectedend=3on a three-row dataset, which is a row index that does not exist. I added three tests that driveget_pagesthrough the real_get_records.