Fix crash in Internal::Load when onIl2CppLoaded list is empty - #180
Open
auag0 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed a crash that occurred in
Internal::Loadwhen no events were registered inonIl2CppLoaded.Problem
The
BNM::ForwardListused foronIl2CppLoadedis a circular linked list.When the list is empty,
lastElementisnullptr. The existing code attempted to accesslastElement->nextwithout checking if the list was empty, leading to a null pointer dereference and a crash.Solution
Added an
IsEmpty()check before entering the event dispatching loop.If no events are registered, the function now returns early safely.
Impact
AddOnLoadedEventhas not been called.Test
Verified that the application no longer crashes when the event list is empty, and events are still called correctly when registered.