fix(deploy): co-locate core and creative context Nitro chunks - #4251
Conversation
…kages/core (3 files)
|
Here's a visual recap of what changed: Open the full interactive recap |
|
Addressed both review findings in 59dd977:
Local validation: Core build, 168 focused tests, and all 66 guards pass. |
There was a problem hiding this comment.
Builder reviewed your changes — looks good ✅
Review Details
Incremental Code Review Summary
The updated PR correctly addresses both previously reported issues. The code-splitting configuration now flows through rolldownConfig, and the grouping predicate includes all AWS Amplify aliases. The new integration coverage builds a temporary Nitro app and verifies that Core and Creative Context are emitted into the same package chunk, which directly tests the failure mode rather than only checking the helper or regex.
I resolved the two stale previous-review threads before this review. Two parallel incremental code-review passes found no new confirmed bugs. They verified Nitro 3's effective Rolldown merge order, checked the supported Node/Netlify/Vercel/AWS Lambda/AWS Amplify and edge preset coverage, and confirmed the new integration test passes. One agent noted unrelated pre-existing temporary-worker h3 resolution failures in the broader suite; the new Nitro test itself passes.
Risk remains standard because this changes shared deployment infrastructure, but the revised approach and targeted emitted-chunk assertion are sound.
🧪 Browser testing: Skipped — PR only modifies backend/build configuration and tests, with no user-facing UI impact.

Summary
Fixes #2752 by keeping
@agent-native/coreand@agent-native/creative-contextin one Nitro server chunk for Node-style presets. Their separate generated chunks form a live-binding cycle that crashes standalone Vercel and Netlify cold starts.Verification
corepack pnpm --filter @agent-native/core exec vitest run src/deploy/build.spec.ts- 166 passedcorepack pnpm guards- all 66 checks passedReferenceError: Cannot access 'xee' before initializationfrom the generated Core chunkFeedback handoff
Source: #product-agent-native-feedback (C0ATH3CCZT4), 263 parent messages across 3 history pages, 2026-08-29 00:00 PDT through 2026-09-03 05:31 PDT. A latest-message search found no newer parent.
One authorized Slack reply was posted for the Clips recording thread, ended with
this was sent from a bot., and the complete thread was read back with no follow-up.