Repository navigation
Conversation
… limit which tabs they can use - the extension hides the values of cookie, set-cookie, authorization and CSRF-token headers it relays, keeping the names, unless the user turns it off in Settings - Settings can limit agents to the tabs they open and the ones the user enables from the popup for a while; other tabs are hidden from tab list, with a note saying how many
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey Namu!
My 2nd suggestion for this tool is about security.
And IMO that's a very important aspect, especially after the changes for version 2.x.
Version 2 allows the agent to have access to all tabs in the browser.
I understand the side of making the process simpler, but I think this presents a high security risk.
Think of a case that you have you internet banking open in a tab (which you aren't looking atm), and your focus is somewhere else, but your agent has access to that too.
Especially consider that it's not only a matter of trusting the agent.
In several case (in companies and also at home) the access is done through a Gateway, so there's somebody already in the middle. Or even on the PC itself, it's not too hard that a malicious app would impersonate the AI agent.
Another vulnerability is that currently all header are available.
That includes cookies and session ID.
Then think again of the case above, with the Internet banking and possible men in the middle.
Now he can steal the users's session...
Changes
The changes are optional, done in the settings.
Commits
Hide credential headers from agents and let the user limit which tabs they can use
Description (from AI)
This branch adds two security controls to Browser MCP: it hides credential headers before they leave the browser, and it lets the user restrict which tabs AI agents are allowed to see and use.
What changed
1. Redaction of credential headers
Cookie,Set-CookieAuthorization,Proxy-AuthorizationX-XSRF-Token,X-CSRF-TokenX-Api-Key,X-Auth-Token,X-Amz-Security-TokenAuthorization, the scheme (e.g.Bearer,Basic) is preserved but the token is hidden.2. Tab access restrictions
tab listand the popup shows a note saying how many are hidden.Files most affected
packages/extension-core/src/background/redact.ts(new)packages/extension-core/src/background/tab-access.ts(new)packages/extension-core/src/background/browser-control.tsapps/extension/src/components/settings-screen.tsxapps/extension/src/components/browser-control-panel.tsxpackages/extension-core/src/storage.tspackages/extension-core/src/types.tspackages/extension-core/src/messages.tspackages/mcp/src/contracts.tspackages/protocol/src/index.ts