Replay data synchronizer remove datasource bugs#48
Draft
philip-khaisman wants to merge 1 commit into
Draft
Conversation
…emoving one from the sync
philip-khaisman
commented
Jun 10, 2026
| @@ -378,7 +378,6 @@ class DataSynchronizerReplay { | |||
| startTimestamp: this.getStartTimeAsTimestamp(), | |||
| endTimestamp: this.getEndTimeAsTimestamp() | |||
| }).then(async () => { | |||
Collaborator
Author
There was a problem hiding this comment.
TODO: Verify that the datasource is indeed being disconnected with this change. Or should it? What happens if we disconnect and then toggle the visualization on. Where will the playback start? I'm assuming it will work since the synchronizer is managing the timestamps
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When calling
removeDatasourceon theDataSynchronizerReplayclass we were making a call that disconnected all datasources from the synchronizer, not just the one passed to the method. This meant that in a client such as the webtak plugin when we toggled one visualization off it stopped the connections of all visualizations.Additionally, the
removeDataSourcemethod publishes aremoveevent which is handled by the data synchronizer replay worker which stops the data synchronizer altogether.Now we only disconnect the datasource that's passed to the
removeDatasourcemethod and we keep the synchronizer working so that the streaming of connected datasources continues.Test