chore: regen WS generated files (drop stale param_note caveats)#172
Merged
Conversation
Regenerated datamaxi/_ws_endpoints.py + _ws_models.py from datamaxi-codegen now that it reads the backend AsyncAPI spec (Bisonai/datamaxi-codegen#53). Only change: the two obsolete param_note caveats are gone (forex; funding-rate — the backend doc-comment ambiguity was fixed in Bisonai/datamaxi-backend#7929). _ws_models.py is unchanged. Nothing in the SDK reads param_note.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Regenerates
datamaxi/_ws_endpoints.py+datamaxi/_ws_models.pyfrom datamaxi-codegen now that it reads the backend's AsyncAPI spec (codegen #53) instead of the route-table regex + param overrides.Sole change: the two obsolete
param_notecaveats are dropped —forex:"fx pair e.g. USD-KRW, no exchange"funding-rate: the "code/doc disagree" note (the backend doc-comment ambiguity was fixed in datamaxi-backend #7929)._ws_models.pyis byte-unchanged. Nothing in the SDK readsparam_note, so this is purely keeping the committed generated files in sync with the generator.Verification
git diff= 2 deletions in_ws_endpoints.py, nothing else.pytest tests/test_ws.py tests/test_async.py: 19 passed.Context
This is the trivial downstream sync noted in codegen #53. A WS drift-guard (
check-ws-python, codegen #47) would automate catching this going forward.Known failures
None.