Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions datamaxi/datamaxi/premium.py
Original file line number Diff line number Diff line change
Expand Up @@ -162,19 +162,19 @@ def __call__( # noqa: C901
params = {}

if source_exchange is not None:
params["sourceExchange"] = source_exchange
params["source_exchange"] = source_exchange

if target_exchange is not None:
params["targetExchange"] = target_exchange
params["target_exchange"] = target_exchange

if asset is not None:
params["asset"] = asset

if source_quote is not None:
params["sourceQuote"] = source_quote
params["source_quote"] = source_quote

if target_quote is not None:
params["targetQuote"] = target_quote
params["target_quote"] = target_quote

if sort is not None:
params["sort"] = sort
Expand Down
12 changes: 9 additions & 3 deletions tests/test_premium.py
Original file line number Diff line number Diff line change
Expand Up @@ -55,10 +55,16 @@ def test_premium_call_param_name_translation():
json=_RESPONSE,
status=200,
)
_client()(source_exchange="binance", conversion_base="USDT", page=2)
_client()(
source_exchange="binance",
target_quote="USDT",
conversion_base="USDT",
page=2,
)
qs = _qs(responses.calls[0])
# camelCase wire keys for exchange params, snake_case for conversion_base
assert qs["sourceExchange"] == ["binance"]
# snake_case wire keys for all params (backend expects snake_case)
assert qs["source_exchange"] == ["binance"]
assert qs["target_quote"] == ["USDT"]
assert qs["conversion_base"] == ["USDT"]
assert qs["page"] == ["2"]

Expand Down
Loading