Repository navigation
feat: artifact delete button with confirm + error banner - #142
Merged
Merged
Conversation
BerryUIKI
force-pushed
the
feat/artifacts-delete
branch
from
August 19, 2026 02:34
3ea0f1a to
0ba2a68
Compare
BerryUIKI
force-pushed
the
feat/artifacts-delete
branch
from
August 19, 2026 03:36
0ba2a68 to
459b1f3
Compare
NoviUIKI
approved these changes
Aug 19, 2026
NoviUIKI
left a comment
Collaborator
There was a problem hiding this comment.
Review summary — PR #142
Verdict: ✅ Approve
Clean, well-contained feature (single file). Verified: typecheck passes, existing artifact tests pass, no whitespace errors.
Critical
- None.
Important
- None.
Suggestions (non-blocking)
- Rename
_onDelete→onDelete(ArtifactsPage.tsx). The underscore prefix and the now-removedvoid _onDelete;marked it as "intentionally unused" — but this PR makes it the active delete handler. The name is now misleading. - Error detail is discarded. The
catchinhandleDeleteArtifactshows the genericfailedToDeleteArtifactbanner and no longer logs the underlying error anywhere. For a desktop app that's hard to debug in the field; consider includingerror.messagein the banner or writing it to a dev-only diagnostic channel. - Minor a11y: the row swap to
<div role="button">handles Enter and Space onkeydown; the ARIA convention is to activate Space onkeyup(so it doesn't fight page scroll). Also, the delete button is invisible until hover/focus — fine for this desktop app, but worth a permanent affordance if touch is ever a target. - Minor UX: the
deleteErrorbanner has no dismiss — it persists until the next delete attempt or navigation.
Strengths
- Correctly solves the nested-button problem: the outer
<button>becomes<div role="button" tabIndex={0}>so the delete button can live inside without invalid HTML nesting, with ae.target !== e.currentTargetguard so its key events don't trigger row selection. - Delete button is keyboard-reachable (
focus:opacity-100) witharia-label/title, and usesstopPropagationso clicking it doesn't select the row. - Confirms before deleting (
window.confirm), consistent withOptionContractTable. - Failure is surfaced in a
role="alert"banner instead ofconsole.error— matches the error-surfacing direction of PR #141. tis now properly typed as(key: MessageKey) => string.
Verification
tsc --noEmit(apps/desktop): passes.ComparisonTableRenderer.test.tsx+ArtifactWindowPage.test.tsx: 9/9 pass.git diff --check: clean.
- Add per-item delete button (stopPropagation, hover reveal) - Confirm via window.confirm before deleting - Surface delete failures in a role=alert banner instead of console.error
NoviUIKI
force-pushed
the
feat/artifacts-delete
branch
from
August 19, 2026 05:17
459b1f3 to
98c0c79
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implement the artifact delete button (task #5).
Changes