Skip to content

Fix/performance#37

Merged
ptesei merged 2 commits intodevelopfrom
fix/performance
Apr 27, 2026
Merged

Fix/performance#37
ptesei merged 2 commits intodevelopfrom
fix/performance

Conversation

@ptesei
Copy link
Copy Markdown
Contributor

@ptesei ptesei commented Apr 24, 2026

  • improve performance using a strore
  • no html changes for retro compatibility

Note

Medium Risk
Changes how tabsActive is derived from editor selection and when it updates, which can affect tab activation behavior (especially with nested tabs) despite being editor-only logic.

Overview
Refactors active-tab syncing so tabsActive is updated once per blockparty/tabs block via a new useSyncTabsActiveForTabsBlock hook, instead of rendering SyncTabsActive inside every nav/panel item.

The sync logic now infers the closest tab item from the current selection/ancestors, verifies ownership to avoid cross-updating nested tabs, and skips dispatches when tabsActive is already correct.

Reviewed by Cursor Bugbot for commit 4ebd332. Bugbot is set up for automated code reviews on this repo. Configure here.

@n-langle
Copy link
Copy Markdown
Contributor

Le fichier GetSynchedID.js ne semble plus utilisé :
https://github.com/BeAPI/blockparty-tabs/blob/fix/performance/src/blockparty-tabs/GetSynchedID.js

@ptesei ptesei merged commit eaf74a2 into develop Apr 27, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants