Skip to content

feat(aliases): add history, history undo, repolist, repoquery, and ch… - #2408

Open
Waqar-Ahmad76 wants to merge 1 commit into
Bash-it:masterfrom
Waqar-Ahmad76:add-my-custom-alias
Open

Waqar-Ahmad76 wants to merge 1 commit into
Bash-it:masterfrom
Waqar-Ahmad76:add-my-custom-alias

Conversation

@Waqar-Ahmad76

@Waqar-Ahmad76 Waqar-Ahmad76 commented Oct 3, 2026 •

Copy link
Copy Markdown

…eck aliases to dnf

Description

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • If my change requires a change to the documentation, I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • If I have added a new file, I also added it to clean_files.txt and formatted it using lint_clean_files.sh.
  • I have added tests to cover my changes, and all the new and existing tests pass.

@seefood seefood left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Inconsistent indentation / alignment: The # comments use a tab + one space before the text, but the # comment column is misaligned. For example, alias dnfmc="dnf makecache" # Generate metadata cache
    uses multiple spaces to pad to a comment column, while the new lines use a tab (or irregular spacing). This breaks the visual alignment pattern established in the existing file.

  2. clean_files.txt not updated: The checklist explicitly says "If I have added a new file, I also added it to clean_files.txt and formatted it" — they didn't tick that box, but since this is an existing file
    (not new), this clause may not strictly apply. Worth checking whether dnf.aliases.bash is already covered by clean_files.txt.

  3. dnf history undo without -y: The dnf history undo alias will prompt for confirmation each time, unlike dnfi/dnfr which use sudo and are one-offs. Not necessarily a bug — it's reasonable to require
    confirmation for undo — but worth calling out.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants