Fix node kind checks - #2768
Merged
Merged
Fix node kind checks#2768
Conversation
… type of `self` step
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changes in bbd7744 have caused these differences in the behaviour of location steps:
descendant-or-selfsteps can lose their name test, when merged with a subsequent step. This makes this query return an empty sequence:a narrower type of a name test in a
selfstep may be overridden by the broadernode(), e.g. inThis is caused by checks in
Path.mergeStepandStep.assignTypethat were changed in bbd7744. With the fix here, both checks now require the test to be one of theNodeTestwildcard singletons (NodeTest.NODE/JNODE/XNODE), rather than to just carry the samekind.