Repository navigation
BAH-4789: Harden FormPrivilegeTable pagination error handling - #142
Open
anushkadubey-star wants to merge 1 commit into
Open
anushkadubey-star wants to merge 1 commit into
anushkadubey-star wants to merge 1 commit into
Conversation
Show an error notification when a first or later privilege page fails, fall back to a default message when the error has none, and stop on a repeated next-page link. Add regression tests for these cases and assert the exact merged privileges and same-origin request URLs. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#141
Improves error handling and pagination safety in
FormPrivilegeTable.Changes
Note: The
loadingstate is not rendered in this component, so resetting it is state cleanup rather than a visible spinner fix. The user-visible improvement is the error notification when privilege loading fails.Validation
git diff --check: passed.No changes were made to
FormBuilderContainer,httpInterceptor, or existing 401/403 redirect behavior.