ci(publish): honour the publish issue's target checklist - #49
Merged
Merged
Conversation
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
BYK
approved these changes
Sep 17, 2026
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Craft publish issue says "Checked targets will be skipped", but nothing implemented that here: Craft never reads the issue (that checklist is consumed by Sentry's external publish controller, which writes a state file), and this workflow always ran
craft publish <version>over all targets. So re-running a partially-completed publish dies onnpm error You cannot publish over the previously published versions, and the post-publish steps (tag, merge the release branch back into the default branch) are never reached.The parse step now derives
--targetflags from the### Targetssection of the issue body:Same change goes out to every BYK repo using this publish.yml (jev-mcp, binpatch, loreai, superset, fossilize); it landed first in BYK/jev-mcp#5.
Link to Devin session: https://app.devin.ai/sessions/23677206622847fe8fdfa0ec81fff5fa
Open in Devin Desktop: https://app.devin.ai/desktop/session/23677206622847fe8fdfa0ec81fff5fa?variant=devin
Requested by: @BYK