Skip to content

ci(publish): honour the publish issue's target checklist - #49

Merged
BYK merged 1 commit into
mainfrom
devin/1789684490-publish-skip-targets
Sep 17, 2026
Merged

BYK merged 1 commit into
mainfrom
devin/1789684490-publish-skip-targets

Conversation

@devin-ai-integration

Copy link
Copy Markdown
Contributor

Summary

The Craft publish issue says "Checked targets will be skipped", but nothing implemented that here: Craft never reads the issue (that checklist is consumed by Sentry's external publish controller, which writes a state file), and this workflow always ran craft publish <version> over all targets. So re-running a partially-completed publish dies on npm error You cannot publish over the previously published versions, and the post-publish steps (tag, merge the release branch back into the default branch) are never reached.

The parse step now derives --target flags from the ### Targets section of the issue body:

unchecked: npm, github  -> (no flags, publish everything)
unchecked: github       -> --target github
none unchecked          -> --target none   # skips all targets, still tags + merges back

Same change goes out to every BYK repo using this publish.yml (jev-mcp, binpatch, loreai, superset, fossilize); it landed first in BYK/jev-mcp#5.

Link to Devin session: https://app.devin.ai/sessions/23677206622847fe8fdfa0ec81fff5fa
Open in Devin Desktop: https://app.devin.ai/desktop/session/23677206622847fe8fdfa0ec81fff5fa?variant=devin
Requested by: @BYK

Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
@devin-ai-integration

Copy link
Copy Markdown
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment, CI, and merge conflict monitoring

@BYK
BYK merged commit 445bfd1 into main Sep 17, 2026
3 checks passed
@BYK
BYK deleted the devin/1789684490-publish-skip-targets branch September 17, 2026 22:37
@github-actions

Copy link
Copy Markdown
Contributor
PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-09-17 22:37 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant