Added SANDee models - #161
Conversation
Included SANDee models from Alvarado et al. 2024, Gerasimov et al. 2024
now is able to read into SANDee
Reading in the SANDee
SherelynA
left a comment
SherelynA
left a comment
There was a problem hiding this comment.
@efrain-alvarado-iii , I just had a couple of comments
There was a problem hiding this comment.
I am not familiar with the values from the evo model, but are the first values for age supposed to be zero @efrain-alvarado-iii ?
There was a problem hiding this comment.
@efrain-alvarado-iii , I am a bit confused about the naming of the evolutionary models, what does each name mean? For example, [SAND_z-0.15_a0.15_age.txt], what does the z, a mean in the names?
| self.path = str(importlib.resources.files('sedkit')/ 'data/models/evolutionary/{}.txt').format(self.name) | ||
| self.path = str(importlib.resources.files('sedkit') / 'data/models/evolutionary/{}.txt').format(self.name) | ||
|
|
||
| if not os.path.exists(self.path): |
There was a problem hiding this comment.
I think this should work, since all the checks are being passed, but I think we could possibly format the two attempts to get the path, instead of just having a if statement that is going to be true even if the evo model you attempt is not the Sandee nor the one's already added. Does that make sense?
2 participants
Added metal-poor evolutionary models from Gerasimov et al. 2024