Skip to content

refactor: web club category emoji 컬럼명 변경#653

Closed
JanooGwan wants to merge 1 commit into
developfrom
codex/rename-web-club-category-emoji
Closed

refactor: web club category emoji 컬럼명 변경#653
JanooGwan wants to merge 1 commit into
developfrom
codex/rename-web-club-category-emoji

Conversation

@JanooGwan
Copy link
Copy Markdown
Contributor

@JanooGwan JanooGwan commented May 29, 2026

규칙에 맞는 브랜치명/커밋 메시지/PR 양식으로 새 PR을 다시 생성하기 위해 닫았습니다.

새 PR: #654

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 29, 2026

Review Change Stack

Caution

Review failed

Pull request was closed or merged during review

📝 Walkthrough

Walkthrough

이 PR은 클럽 엔티티의 imageUrl 필드를 categoryEmoji 필드로 일관되게 교체합니다. 도메인 모델, 데이터베이스 스키마, 이벤트 계약, API 응답, Slack 알림 서비스, 그리고 모든 관련 테스트가 함께 업데이트됩니다.

Changes

Club Image URL to Category Emoji Migration

Layer / File(s) Summary
Domain Model and Database Schema Update
src/main/java/gg/agit/konect/domain/website/model/WebClub.java, src/main/resources/db/migration/V85__rename_web_club_image_url_to_category_emoji.sql, src/test/java/gg/agit/konect/support/fixture/WebClubFixture.java
WebClub 엔티티에서 imageUrl 필드(컬럼 image_url)를 제거하고 categoryEmoji 필드(컬럼 category_emoji)를 추가합니다. 데이터베이스 마이그레이션이 테이블 컬럼을 이름 변경하며, 테스트 픽스처가 새 필드로 업데이트됩니다.
Club Information Update Event
src/main/java/gg/agit/konect/domain/club/event/ClubInformationUpdateRequestedEvent.java, src/test/java/gg/agit/konect/unit/domain/club/service/ClubRegistrationRequestServiceTest.java
ClubInformationUpdateRequestedEvent 레코드의 currentImageUrl 컴포넌트를 currentCategoryEmoji로 변경하고, from() 팩토리 메서드가 request.getClub().getCategoryEmoji()에서 값을 가져오도록 갱신합니다.
API Response DTOs
src/main/java/gg/agit/konect/domain/website/dto/WebsiteClubDetailResponse.java, src/main/java/gg/agit/konect/domain/website/dto/WebsiteClubsResponse.java
WebsiteClubDetailResponseWebsiteClubsResponse.ClubResponseimageUrlcategoryEmoji로 교체하여 API 응답 스키마를 갱신합니다. 각 팩토리 메서드가 club.getCategoryEmoji() 값을 전달하도록 변경됩니다.
Slack Notification Service Integration
src/main/java/gg/agit/konect/infrastructure/slack/service/SlackNotificationService.java, src/main/java/gg/agit/konect/infrastructure/slack/listener/ClubRegistrationRequestSlackListener.java
SlackNotificationService.notifyClubInformationUpdateRequest()의 파라미터가 currentImageUrl에서 currentCategoryEmoji로 변경되며, 메시지 포맷 블록도 갱신됩니다. ClubRegistrationRequestSlackListener가 업데이트된 파라미터로 서비스를 호출합니다.
Integration and Unit Tests
src/test/java/gg/agit/konect/integration/domain/website/WebsiteApiTest.java, src/test/java/gg/agit/konect/unit/infrastructure/slack/listener/ClubRegistrationRequestSlackListenerTest.java
웹 API 통합 테스트가 세 가지 엔드포인트에서 응답의 categoryEmoji 필드를 검증합니다. Slack 리스너 테스트가 모의 호출 인자 목록에 event.currentCategoryEmoji()를 포함하도록 갱신됩니다.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

  • BCSDLab/KONECT_BACK_END#642: Main PR updates the already-added club information update flow from PR #642 by changing ClubInformationUpdateRequestedEvent and downstream Slack listener/SlackNotificationService to use currentCategoryEmoji instead of currentImageUrl.
  • BCSDLab/KONECT_BACK_END#651: Both PRs modify the "club information update requested" payload wiring by changing ClubInformationUpdateRequestedEventClubRegistrationRequestSlackListenerSlackNotificationService.notifyClubInformationUpdateRequest(...) argument/formatting in overlapping code paths.

Suggested labels

리팩토링

Suggested reviewers

  • dh2906

Poem

🐰 사진 사라지고 이모지 남아,
동아리는 분과를 밝혀 드러내고,
데이터 흐름 정렬되고,
슬랙 알림도 따라 춤춘다네,
일관된 변화, 반반 했습니다! 📚✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed PR 제목이 변경 사항의 핵심을 명확하게 설명하고 있습니다. 컬럼명 변경(image_url -> emoji)이라는 주요 변경 내용을 간결하게 나타냅니다.
Description check ✅ Passed PR 설명이 변경 사항과 관련이 있으며, 작업 내용과 검증 단계를 구체적으로 기술하고 있습니다.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/rename-web-club-category-emoji

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@JanooGwan JanooGwan changed the title refactor: web club category emoji 컬럼명 변경 refactor: 컬럼명 변경(image_url -> emoji) May 29, 2026
@JanooGwan JanooGwan self-assigned this May 29, 2026
@JanooGwan JanooGwan added 리팩토링 리팩터링을 위한 이슈입니다. DB DB 마이그레이션을 위한 라벨입니다. labels May 29, 2026
@github-actions
Copy link
Copy Markdown

🧪 JaCoCo Coverage Report (Changed Files)

Summary

  • Overall Coverage: 80.0% ✅
  • Covered Lines: 88 / 110
  • Changed Files: 6

Coverage by File

Class Coverage Lines Status
SlackNotificationService
gg.agit.konect.infrastructure.slack.service
58.5% 31/53 ⚠️
ClubInformationUpdateRequestedEvent
gg.agit.konect.domain.club.event
100.0% 20/20
ClubRegistrationRequestSlackListener
gg.agit.konect.infrastructure.slack.listener
100.0% 37/37

📊 View Workflow Run

@JanooGwan JanooGwan changed the title refactor: 컬럼명 변경(image_url -> emoji) refactor: web club category emoji 컬럼명 변경 May 29, 2026
@JanooGwan JanooGwan closed this May 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DB DB 마이그레이션을 위한 라벨입니다. 리팩토링 리팩터링을 위한 이슈입니다.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant